On Wed, Mar 29, 2017 at 1:02 PM, Jeff Moyer <[email protected]> wrote:
> Dan Williams <[email protected]> writes:
>
>> +check_min_kver()
>> +{
>> + local ver="$1"
>> + : "${KVER:=$(uname -r)}"
>> +
>> + [ -n "$ver" ] || return 1
>> + [[ "$ver" == "$(echo -e "$ver\n$KVER" | sort -V | head -1)" ]]
>> +}
>> +
>> +check_min_kver "4.11" || { echo "kernel $KVER may lack latest device-dax
>> fixes"; exit $rc; }
>
> Can we stop with this kernel version checking, please? Test to see if
> you can create a device dax instance. If not, skip the test. If so,
> and if you have a kernel that isn't fixed, so be it, you'll get
> failures.
I'd rather not. It helps me keep track of what went in where. If you
want to run all the tests on a random kernel just do:
KVER="4.11.0" make check
>
>> +
>> +set -e
>> +trap 'err $LINENO' ERR
>> +
>> +if ! fio --enghelp | grep -q "dev-dax"; then
>> + echo "fio lacks dev-dax engine"
>> + exit 77
>> +fi
>> +
>> +dev=$(./dax-dev)
>> +for align in 4k 2m 1g
>> +do
>> + json=$($NDCTL create-namespace -m dax -a $align -f -e $dev)
>> + chardev=$(echo $json | jq -r ". | select(.mode == \"dax\") |
>> .daxregion.devices[0].chardev")
>> + if [ align = "1g" ]; then
>> + bs="1g"
>> + else
>> + bs="2m"
>> + fi
>
> I'm not sure the blocksize even matters.
>
iirc it affects the alignment of the mmap() request. So for example
bs=4k should fail when the alignment is larger.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
