On Wed, Jun 14, 2017 at 5:45 AM, Michal Hocko <[email protected]> wrote: > On Tue 13-06-17 16:08:26, Dan Williams wrote: >> Turn the macro into a static inline and rewrite the condition checks for >> better readability in preparation for adding another condition. >> >> Cc: Jan Kara <[email protected]> >> Cc: Andrew Morton <[email protected]> >> Reviewed-by: Ross Zwisler <[email protected]> >> [ross: fix logic to make conversion equivalent] >> Acked-by: "Kirill A. Shutemov" <[email protected]> >> Signed-off-by: Dan Williams <[email protected]> > > This is really a nice deobfuscation! Please note this will conflict with > http://lkml.kernel.org/r/[email protected] > > > Trivial to resolve but I thought I should give you a heads up.
Hmm, I'm assuming that vma_is_dax() should override PRCTL_THP_DISABLE? ...and while we're there should vma_is_dax() also override VM_NOHUGEPAGE? This is with the assumption that the reason to turn off huge pages is to avoid mm pressure, dax exerts no such pressure. > Acked-by: Michal Hocko <[email protected]> Thanks for the heads up. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
