On Mon, Jul 10, 2017 at 11:32 AM, Matthew Wilcox <[email protected]> wrote:
> From: Matthew Wilcox <[email protected]>
>
> There was no need to have a minimum size of 4MB for NV-DIMMs; it was
> just a sanity check. Keep a check that it's at least one page in size
> because we really can't add less than a page to the memory map. Promote
> the print statement from 'debug' level to 'warning', since there was no
> information for my colleague who stumbled over this problem while
> attempting to add a 2MB chunk of memory.
>
> Reported-by: Cheng-mean Liu <[email protected]>
> Signed-off-by: Matthew Wilcox <[email protected]>
> ---
> drivers/nvdimm/namespace_devs.c | 6 +++---
> include/uapi/linux/ndctl.h | 4 ----
> 2 files changed, 3 insertions(+), 7 deletions(-)
Looks good to me, just one fix up:
>
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index 5f1c6756e57c..95169308078a 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -1689,9 +1689,9 @@ struct nd_namespace_common
> *nvdimm_namespace_common_probe(struct device *dev)
> }
>
> size = nvdimm_namespace_capacity(ndns);
> - if (size < ND_MIN_NAMESPACE_SIZE) {
> - dev_dbg(&ndns->dev, "%pa, too small must be at least %#x\n",
> - &size, ND_MIN_NAMESPACE_SIZE);
> + if (size < PAGE_SIZE) {
If we're going to change the print level away from 'debug' then I
think this should be "if (size && size < PAGE_SIZE)". The sub-system
pre-creates 0-sized devices that are later configured into full
namespaces, in those cases we shouldn't fire the warning.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
