On Tue, Sep 5, 2017 at 6:28 PM, Yasunori Goto <[email protected]> wrote:
> > Actually, since there's some other fixups needed on this series, I'll let > > you resend this with the "attribute packed" statements added back in. > I'll > > follow on later with kernel and ndctl patches to remove the ones that are > > not needed. > > Hmm, since I may still misunderstand yet, let me confirm it. > > In my next patch, "attribute packed" statements should be added > to ALL of structures again. > > (that is, the followings should have "attribute packed" again. > - nd_cmd_translate_spa > - nd_cmd_ars_err_inj > - nd_cmd_ars_err_inj_clear > - nd_cmd_ars_err_inj_stat > ) > > Is this correct? > Yes. Then I can address all the places where the cleanup can happen in one patch rather than just doing this one change in isolation. For example, some of the existing ones in ndctl.h need conversion, as well as some of the payloads in hpe.h. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
