On Thu 28-09-17 18:21:23, Dan Williams wrote: > This flag is deprecated in favor of the vma_is_dax() check in > transparent_hugepage_enabled() added in commit baabda261424 "mm: always > enable thp for dax mappings" > > Cc: Jan Kara <[email protected]> > Cc: Jeff Moyer <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Ross Zwisler <[email protected]> > Signed-off-by: Dan Williams <[email protected]>
I like this! You can add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > drivers/dax/device.c | 1 - > fs/ext4/file.c | 1 - > fs/xfs/xfs_file.c | 2 -- > 3 files changed, 4 deletions(-) > > diff --git a/drivers/dax/device.c b/drivers/dax/device.c > index ed79d006026e..74a35eb5e6d3 100644 > --- a/drivers/dax/device.c > +++ b/drivers/dax/device.c > @@ -450,7 +450,6 @@ static int dax_mmap(struct file *filp, struct > vm_area_struct *vma) > return rc; > > vma->vm_ops = &dax_vm_ops; > - vma->vm_flags |= VM_HUGEPAGE; > return 0; > } > > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index 0cc9d205bd96..a54e1b4c49f9 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -352,7 +352,6 @@ static int ext4_file_mmap(struct file *file, struct > vm_area_struct *vma) > file_accessed(file); > if (IS_DAX(file_inode(file))) { > vma->vm_ops = &ext4_dax_vm_ops; > - vma->vm_flags |= VM_HUGEPAGE; > } else { > vma->vm_ops = &ext4_file_vm_ops; > } > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index dece8fe937f5..c0e0fcbe1bd3 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1130,8 +1130,6 @@ xfs_file_mmap( > { > file_accessed(filp); > vma->vm_ops = &xfs_file_vm_ops; > - if (IS_DAX(file_inode(filp))) > - vma->vm_flags |= VM_HUGEPAGE; > return 0; > } > > -- Jan Kara <[email protected]> SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
