Re: [PATCH 09/12] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

[Marta Rybczynska]

> @@ -429,10 +429,7 @@ static void __nvme_submit_cmd(struct nvme_queue *nvmeq,
> {
>       u16 tail = nvmeq->sq_tail;
> 
> -     if (nvmeq->sq_cmds_io)
> -             memcpy_toio(&nvmeq->sq_cmds_io[tail], cmd, sizeof(*cmd));
> -     else
> -             memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));
> +     memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));
> 

Why is it always memcpy() and not memcpy_toio()? I'd expect something like
if (nvmeq->sq_cmds_is_io)
        memcpy_toio(&nvmeq->sq_cmds_io[tail], cmd, sizeof(*cmd));
else
        memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));

Marta
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm