On Thu, 2018-02-08 at 12:54 -0800, Dan Williams wrote: > On Thu, Feb 8, 2018 at 12:49 PM, Vishal Verma <[email protected] > om> wrote: > > Add support for the smart injection command in the nvdimm unit test > > framework. This allows for directly injecting to smart fields and > > flags > > that are supported in the injection command. If the injected values > > are > > past the threshold, then an acpi notification is also triggered. > > > > Also update the default smart ctrl_temperature to start out below > > the > > default threshold instead of at it. This prevents arbitrary smart > > injections from triggering an acpi notification > > Any sentence starting with "Also" in a changelog is almost always an > indication to split the patch in 2 so the topics can be independently > bisected.
True, I did read that advice somewhere, but I figured these are related enough that they can go together. But I agree separating them for bisectability can be useful, I'll send a new revision _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
