When an invalid namespace was specified, inject-error would simply walk through a loop trying to matching namespace, and at the end, exit out silently. This could make it look as though the operation had been successful, when in reality, nothing had been done.
Fix to print a message, and exit with an ENXIO when this happens. Signed-off-by: Vishal Verma <[email protected]> --- ndctl/inject-error.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ndctl/inject-error.c b/ndctl/inject-error.c index 9b9d821..efa9f92 100644 --- a/ndctl/inject-error.c +++ b/ndctl/inject-error.c @@ -338,7 +338,8 @@ static int do_inject(const char *namespace, struct ndctl_ctx *ctx) } } - return 0; + error("%s: no such namespace\n", namespace); + return rc; } int cmd_inject_error(int argc, const char **argv, void *ctx) -- 2.14.3 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
