On Fri, Feb 16, 2018 at 4:07 PM, Dave Jiang <[email protected]> wrote: > Adding firmware output of firmware information when ndctl list -D -F is used. > Components displayed are current firmware version, updated firmware version, > and if a coldboot is required (firmware updated). > > Signed-off-by: Dave Jiang <[email protected]> > Tested-by: Jeff Moyer <[email protected]> > --- > v5: > - Changed next_version to updated version to be in sync with DSM spec. > - Changed emission of "unknown" string to -1 for error versions. > > v4: > - Remove output when updated_version is 0. That indicates no updated firmware. > > v3: > - Fixed issue where it skips displaying rest of the details if there's no > firmware details. > > v2: > - Added copyright > - Added support for human readable option (hex) for versions > - Removed check against CMD_CALL as it's not useful > > Documentation/ndctl/ndctl-list.txt | 13 +++++ > ndctl/Makefile.am | 1 > ndctl/list.c | 13 +++++ > ndctl/util/json-firmware.c | 91 > ++++++++++++++++++++++++++++++++++++ > util/json.h | 2 + > 5 files changed, 120 insertions(+) > create mode 100644 ndctl/util/json-firmware.c > > diff --git a/Documentation/ndctl/ndctl-list.txt > b/Documentation/ndctl/ndctl-list.txt > index fc07a71..85b87d4 100644 > --- a/Documentation/ndctl/ndctl-list.txt > +++ b/Documentation/ndctl/ndctl-list.txt > @@ -110,6 +110,19 @@ include::xable-region-options.txt[] > } > } > > +-F:: > +--firmware:: > + Include dimm firmware info in the listing. For example: > +[verse] > +{ > + "dev":"nmem0", > + "firmware":{ > + "current_version":0, > + "next_version":1, > + "coldboot_required":true > + }
Sorry for the bikeshedding, but I think 'next_version' is more clear than 'updated_version' and 'coldboot_required' should be 'need_powercycle'. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
