On Wed, Feb 21, 2018 at 2:28 PM, Verma, Vishal L <[email protected]> wrote: > > On Wed, 2018-02-21 at 15:06 -0700, Dave Jiang wrote: >> Adding all option to allow ndctl to update all DIMMs at once. > > I was going to ask that we should also update the documentation for > this command to include the new 'all' behavior, but it looks like > during the revisions of the original series, the documentation update > to list the options explicitly got dropped? > > Anyway, can you re-add those, and also talk about --dimm=all there. > > On a side note, should we make this more inline with other dimm > commands, such as xable-dimm or read/write-labels, where the dimm name > (or 'all') is a non-option argument? That would make it something like: > > ndctl update-firmware --firmware=<file> nmem0 (or 'all)
Sounds good to me, but we should still silently support -d for just this command since it appeared in a released version and user interfaces are forever. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
