On Thu, Feb 22, 2018 at 12:49 PM, Dave Jiang <dave.ji...@intel.com> wrote:
> update-firmware is missing verbose option for debug outputs. Also adding
> additional error outs to give better indication if something has failed
> and why.
> Signed-off-by: Dave Jiang <dave.ji...@intel.com>
> Reviewed-by: Dan Williams <dan.j.willi...@intel.com>

On second look, now that we are allowing multiple DIMMs to be updated
in one invocation, these runtime error messages should be of the form:

    "%s: message...\n", ndctl_dimm_get_devname(uctx->dimm)

...note the "\n", that seems to be missing on quite a few of these
error() calls, I missed that earlier.
Linux-nvdimm mailing list

Reply via email to