For systems that don't support NUMA, numactl gives a loud and fatal error:
# numactl -N 0 ls
numactl: This system does not support NUMA policy
Follow this model in ndctl for NUMA based filtering:
# ./ndctl/ndctl list --numa-node=0
Error: This system does not support NUMA
This is done instead of just quietly filtering out all dimms, regions and
namespaces because the NUMA node they were trying to match didn't exist in
the system.
Signed-off-by: Ross Zwisler <[email protected]>
Suggested-by: Dan Williams <[email protected]>
---
util/filter.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/util/filter.c b/util/filter.c
index 291d7ed..fdc46a3 100644
--- a/util/filter.c
+++ b/util/filter.c
@@ -14,7 +14,10 @@
#include <string.h>
#include <stdlib.h>
#include <limits.h>
+#include <unistd.h>
+#include <sys/stat.h>
#include <util/util.h>
+#include <sys/types.h>
#include <ndctl/ndctl.h>
#include <util/filter.h>
#include <ndctl/libndctl.h>
@@ -328,6 +331,13 @@ int util_filter_walk(struct ndctl_ctx *ctx, struct
util_filter_ctx *fctx,
}
if (param->numa_node && strcmp(param->numa_node, "all") != 0) {
+ struct stat st;
+
+ if (stat("/sys/devices/system/node", &st)) {
+ error("This system does not support NUMA\n");
+ return -EINVAL;
+ }
+
numa_node = strtol(param->numa_node, &end, 0);
if (end == param->numa_node || end[0]) {
error("invalid numa_node: '%s'\n", param->numa_node);
--
2.14.3
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
