The FW_START DSM should have input/out of 0/8, the code incorrectly
is passing in 4/4. This is causing failure with newer BIOS that check
the input/output parameters more strictly.

Signed-off-by: Dave Jiang <[email protected]>
---
 ndctl/lib/intel.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
index 3c4509e4..ba210e1c 100644
--- a/ndctl/lib/intel.c
+++ b/ndctl/lib/intel.c
@@ -449,8 +449,8 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_start(struct 
ndctl_dimm *dimm)
 
        BUILD_ASSERT(sizeof(struct nd_intel_fw_start) == 8);
 
-       cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE,
-                       sizeof(cmd->intel->start) - 4, 4);
+       cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE, 0,
+                       sizeof(cmd->intel->start));
        if (!cmd)
                return NULL;
 

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to