On Tue, Apr 10, 2018 at 3:06 PM, Dave Jiang <[email protected]> wrote:
> Providing an API call in libndctl to support accessing the region deep_flush
> in sysfs.
>
> Signed-off-by: Dave Jiang <[email protected]>
> ---
>
> v2: Cover case where deep_flush doesn't exist, i.e. memmap=nn!ss. (Dan)
>
> ndctl/lib/libndctl.c | 35 +++++++++++++++++++++++++++++++++++
> ndctl/lib/libndctl.sym | 1 +
> ndctl/libndctl.h | 1 +
> 3 files changed, 37 insertions(+)
>
> diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> index 580a450e..c34f1e09 100644
> --- a/ndctl/lib/libndctl.c
> +++ b/ndctl/lib/libndctl.c
> @@ -181,6 +181,8 @@ struct ndctl_region {
> FILE *badblocks;
> struct badblock bb;
> enum ndctl_persistence_domain persistence_domain;
> + /* file descriptor for deep flush sysfs entry */
> + int flush_fd;
> };
>
> /**
> @@ -511,6 +513,8 @@ static void free_region(struct ndctl_region *region)
> free(region->region_path);
> if (region->badblocks)
> fclose(region->badblocks);
> + if (region->flush_fd > 0)
> + close(region->flush_fd);
> free(region);
> }
>
> @@ -1049,6 +1053,14 @@ NDCTL_EXPORT unsigned long long
> ndctl_region_get_resource(struct ndctl_region *r
> return strtoull(buf, NULL, 0);
> }
>
> +NDCTL_EXPORT int ndctl_region_deep_flush(struct ndctl_region *region)
> +{
> + int rc = pwrite(region->flush_fd, "1", 1, 0);
Make this write "1\n" to match standard sysfs manipulation done by
"echo" that includes a newline.
> +
> + return (rc == -1) ? -errno : 0;
> +}
> +
> +
> NDCTL_EXPORT const char *ndctl_bus_get_cmd_name(struct ndctl_bus *bus, int
> cmd)
> {
> return nvdimm_bus_cmd_name(cmd);
> @@ -1791,6 +1803,7 @@ static void *add_region(void *parent, int id, const
> char *region_base)
> struct ndctl_bus *bus = parent;
> struct ndctl_ctx *ctx = bus->ctx;
> char *path = calloc(1, strlen(region_base) + 100);
> + int perm;
>
> if (!path)
> return NULL;
> @@ -1866,6 +1879,28 @@ static void *add_region(void *parent, int id, const
> char *region_base)
> else
> region->persistence_domain = region_get_pd_type(buf);
>
> + sprintf(path, "%s/deep_flush", region_base);
> + region->flush_fd = open(path, O_RDWR);
Make this O_CLOEXEC, so we don't leak fds on exec.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
