Static analysis warns that we may be closing a negative 'fd'. Fix this
by closing before invalidating the flush_fd with a -1 in add_region()
Fixes: commit c64cc15 ("ndctl: add support in libndctl to provide deep flush")
Cc: Dave Jiang <[email protected]>
Signed-off-by: Vishal Verma <[email protected]>
---
ndctl/lib/libndctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
index ad5ab9a..59ea82a 100644
--- a/ndctl/lib/libndctl.c
+++ b/ndctl/lib/libndctl.c
@@ -1929,8 +1929,8 @@ static void *add_region(void *parent, int id, const char
*region_base)
perm = strtol(buf, NULL, 0);
if (perm == 0) {
- region->flush_fd = -1;
close(region->flush_fd);
+ region->flush_fd = -1;
}
out:
--
2.14.3
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
