On Tue, Apr 17, 2018 at 12:20:44AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault and huge_fault
> handler. For now, this is just documenting that the
> function returns a VM_FAULT value rather than an errno.
> Once all instances are converted, vm_fault_t will become
> a distinct type.
I'm not sure what you mean by "vm_fault_t will become a distinct type"? Do
you mean you'll make it into an enum, i.e.:
enum vm_fault_t {
VM_FAULT_OOM = 0x0001,
VM_FAULT_SIGBUS = 0x0002,
VM_FAULT_MAJOR = 0x0004,
VM_FAULT_WRITE = 0x0008,
VM_FAULT_HWPOISON = 0x0010,
VM_FAULT_HWPOISON_LARGE = 0x0020,
VM_FAULT_NOPAGE = 0x0100,
VM_FAULT_LOCKED = 0x0200,
VM_FAULT_RETRY = 0x0400,
VM_FAULT_FALLBACK = 0x0800,
VM_FAULT_DONE_COW = 0x1000,
VM_FAULT_NEEDDSYNC = 0x2000,
};
If so, I think that would be great for readability. Right now I look up the
definition of vm_fault_t and see it's typedef'd to an int, and that doesn't
give me as much info as the above enum would.
If this is the plan, I don't understand why you need to make all the site
conversions first?
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
>
> Previously vm_insert_mixed() returns err which driver
> mapped into VM_FAULT_* type. The new function
> vmf_insert_mixed() will replace this inefficiency by
> returning VM_FAULT_* type.
>
> Signed-off-by: Souptick Joarder <[email protected]>
> Reviewed-by: Matthew Wilcox <[email protected]>
> ---
> v2: Modified the change log
>
> v3: Updated the change log
You've only got a v2. :)
Sure, the code looks correct. You can add:
Reviewed-by: Ross Zwisler <[email protected]>
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
