> > Thank you very much, I made a v2 patch by referring to your sample patch. > > > > Going back to the OPT_STRING_LIST, I think it is necessary for ndctl. > > Because the other options in monitor like --dimm-event, --bus-event > > also need to support multiple space-separated arguments, these options > > should be made as a string_list. > > Ok, yes, lets bring in string_list for that case. >
Could you merge the OPT_STRING_LIST first? > > One more question is that do you think it is necessary for ndctl to > > copy OPT_FILENAME in parse_option from git? The difference between > > OPT_FILENAME and OPT_STRING is that there is an additional > > fix_filename() in OPTION_FILENAME to process file's path. Considering > > that ndctl monitor also has file options like --logfile, --conf-file, I > > think we'd better > to copy it. > > Yes, let's copy git's lead for filename fixups. > OK, I will make a patch for adding the OPTION_FILENAME to parse_option. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
