When I ran the command # ndctl list --dimm="all nmem1 nmem2", I found only "nmem1" and "nmem2" can be listed, the keyword "all" was ignored. I want to confirm is this result expected? If not, I will make a follow up patch to fix this bug.
> -----Original Message----- > From: Linux-nvdimm [mailto:[email protected]] On Behalf Of Qi, > Fuli > Sent: Thursday, April 19, 2018 11:10 AM > To: 'Verma, Vishal L' <[email protected]>; Williams, Dan J > <[email protected]> > Cc: [email protected] > Subject: RE: [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to support > multiple > space-seperated arguments > > > From: Verma, Vishal L [mailto:[email protected]] > > Sent: Thursday, April 19, 2018 1:06 AM > > To: Williams, Dan J <[email protected]>; Qi, Fuli/斉 福利 > > <[email protected]> > > Cc: [email protected] > > Subject: Re: [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to > > support multiple space-seperated arguments > > > > On Wed, 2018-04-18 at 07:31 -0700, Dan Williams wrote: > > > On Tue, Apr 17, 2018 at 11:32 PM, QI Fuli <[email protected]> wrote: > > > > This patch refactors util_<obj>_filter to support multiple space- > > > > seperated arguments. Currently, only one <object> can be filtered > > > > by <object>'s name in util_<obj>_filter(). As a result, when users > > > > want to moniotr multiple dimms, they have to run multiple monitor > > > > processes. This feature teachs the > > > > util_dimm_filter() that the "ident" argument maybe a > > > > space-seperatd string which includes multiple dimm_names. > > > > Therefore the monitor can filter multiple dimms in one process. > > > > > > > > Signed-off-by: QI Fuli <[email protected]> > > > > Signed-off-by: Dan Williams <[email protected]> > > > > I'll fix up the tags like so: > > > > Based-on-a-patch-by: Dan Williams <[email protected]> > > Reviewed-by: Dan Williams <[email protected]> > > Signed-off-by: QI Fuli <[email protected]> > > > > > > Thanks, > > -Vishal > > > > > > > > > > Change log since v1: > > > > - Removing OPT_STRING_LIST from parse-option > > > > > > Looks good: > > > > > > Reviewed-by: Dan Williams <[email protected]> > > Thank you very much. > - Qi > _______________________________________________ > Linux-nvdimm mailing list > [email protected] > https://lists.01.org/mailman/listinfo/linux-nvdimm _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
