On Fri, 27 Apr 2018, Souptick Joarder wrote:

> Hi Matthew/ Ross,
> 
> There are two changes exist in mm/huge_memory.c as part of this
> patch. vmf_insert_pfn_pmd() and vmf_insert_pfn_pud() functions are
> invoked from this patch.
> 
> Shall we put both in a single patch that it will easy to bisect in case
> we have any issue ?
> 

Please put them into a single patch, there's no reason to convert

int foo() -> vm_fault_t foo()

but leave

int bar()
{
        return foo()
}

It would be best just to convert all callers to also return vm_fault_t as 
I outlined in my response.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to