> -----Original Message-----
> From: Dan Williams [mailto:[email protected]]
> Sent: Friday, May 4, 2018 12:26 PM
> To: Qi, Fuli/斉 福利 <[email protected]>
> Cc: linux-nvdimm <[email protected]>
> Subject: Re: [PATCH v5 1/4] ndctl, util: add OPTION_FILENAME to parse_opt_type
>
> On Thu, Apr 26, 2018 at 4:30 AM, QI Fuli <[email protected]> wrote:
> > This patch borrows the OPTION_FILENAME from git to ndctl to make sure
> > filename is correct. Some related refactoring is also included:
> > - adds parse_options_prefix() interface
> > - moves is_absolute from util/help.c to util/util.c
> > - adds a new file util/abspath.c
> >
> > Signed-off-by: QI Fuli <[email protected]>
> >
> [..]
> > diff --git a/util/abspath.c b/util/abspath.c new file mode 100644
> > index 0000000..fdf4090
> > --- /dev/null
> > +++ b/util/abspath.c
> > @@ -0,0 +1,28 @@
> > +/* originally copied from git */
>
> Lets say the source file name that it came from in and get and add the
> license.
>
> /* SPDX-License-Identifier: GPL-2.0 */
> /* originally copied from git/abspath.c */
>
> Otherwise, this patch looks good to me.
>
Thank you for your comment.
I will make a new version and add the license.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
