On Fri, May 11, 2018 at 9:22 AM, Verma, Vishal L <vishal.l.ve...@intel.com> wrote: > On Fri, 2018-05-11 at 16:15 +0000, Verma, Vishal L wrote: >> On Fri, 2018-05-11 at 09:03 -0700, Dan Williams wrote: >> > On Fri, May 11, 2018 at 9:00 AM, Verma, Vishal L >> > <vishal.l.ve...@intel.com> wrote: >> > > On Thu, 2018-05-10 at 16:47 -0700, Dave Jiang wrote: >> > > > Compiler spits out warning with -D_FORTIFY_SOURCE=2 and -O0. Moving >> > > > to >> > > > -O2 >> > > > to remove warnings. >> > > > >> > > > Signed-off-by: Dave Jiang <dave.ji...@intel.com> >> > > > --- >> > > > README.md | 2 +- >> > > > autogen.sh | 2 +- >> > > > 2 files changed, 2 insertions(+), 2 deletions(-) >> > > > >> > > > diff --git a/README.md b/README.md >> > > > index 899dcbb8..e0bc5b7b 100644 >> > > > --- a/README.md >> > > > +++ b/README.md >> > > > @@ -6,7 +6,7 @@ sub-system in the Linux kernel >> > > > Build >> > > > ===== >> > > > `./autogen.sh` >> > > > -`./configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc -- >> > > > libdir=/usr/lib64` >> > > > +`./configure CFLAGS='-g -O2' --prefix=/usr --sysconfdir=/etc -- >> > > > libdir=/usr/lib64` >> > > > `make` >> > > > `make check` >> > > > `sudo make install` >> > > > diff --git a/autogen.sh b/autogen.sh >> > > > index a23cf53c..2a52688b 100755 >> > > > --- a/autogen.sh >> > > > +++ b/autogen.sh >> > > > @@ -24,5 +24,5 @@ echo "------------------------------------------- >> > > > -- >> > > > ---- >> > > > ---------------" >> > > > echo "Initialized build system. For a common configuration please >> > > > run:" >> > > > echo "------------------------------------------------------------ >> > > > ----" >> > > > echo >> > > > -echo "./configure CFLAGS='-g -O0' $args" >> > > > +echo "./configure CFLAGS='-g -O2' $args" >> > > > echo >> > > >> > > Should we also add -O2 to my_CFLAGS in configure.ac, or leave that to >> > > the >> > > user? >> > >> > Hmm, does it get in the way of the distro specified CFLAGS? >> >> rpmbuild CFLAGS seem to add to the ones specified here. Not sure what >> would >> happen if both -O1 and -O2 were present for example.. > > From the gcc manual, > > If you use multiple -O options, with or without level numbers, > the last such option is the one that is effective. > > So the distro CFLAGS should append to/override anything we specify in > my_CFLAGS. >
Ok, cool. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
