On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > From: Dave Jiang <[email protected]> > > > > The function return values are confusing with the way the function is > > named. We expect a true or false return value but it actually returns > > 0/-errno. This makes the code very confusing. Changing the return values > > to return a bool where if DAX is supported then return true and no DAX > > support returns false. > > > > Signed-off-by: Dave Jiang <[email protected]> > > Signed-off-by: Ross Zwisler <[email protected]> > > Looks ok, do you want me to pull the first two patches through the xfs > tree? > > Reviewed-by: Darrick J. Wong <[email protected]>
Thanks for the review. I'm not sure what's best. If you do that then Mike will need to have a DM branch for the rest of the series based on your stable commits, yea? Mike what would you prefer? _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
