On 8 June 2018 at 17:03, Michael S. Tsirkin <m...@redhat.com> wrote: > Pull requests are somewhat different, they are usually tested for lack > of warnings. This change didn't arrive as a result of a pull request > maybe that's why it slipped through the cracks. Peter? > > Maybe we need a "pedantic" flag to fail on any warnings, or just catch > output to stderr.
If there's a situation that shouldn't exist in the tree (ie a bug), then make check should catch it, and result in a failure, not just printing random stuff to stderr. Otherwise I'm not going to notice it, whether I'm applying a pull request or an individual patch. thanks -- PMM _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm