On Mon, 2018-06-25 at 17:42 +0900, QI Fuli wrote:
> This patch adds controller temperature threshold to list.
> When the dimm-controller-temperature event fires, users need to know
> the current controller temperature threshold value.
>
> Signed-off-by: QI Fuli <[email protected]>
> ---
> ndctl/util/json-smart.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/ndctl/util/json-smart.c b/ndctl/util/json-smart.c
> index 9482b35..d590b0c 100644
> --- a/ndctl/util/json-smart.c
> +++ b/ndctl/util/json-smart.c
> @@ -47,6 +47,18 @@ static void smart_threshold_to_json(struct ndctl_dimm
> *dimm,
> "temperature_threshold", jobj);
> }
>
> + if (alarm_control & ND_SMART_TEMP_TRIP) {
I think you want to use ND_SMART_CTEMP_TRIP here.
> + unsigned int temp;
> + double t;
> +
> + temp =
> ndctl_cmd_smart_threshold_get_ctrl_temperature(cmd);
> + t = ndctl_decode_smart_temperature(temp);
> + jobj = json_object_new_double(t);
> + if (jobj)
> + json_object_object_add(jhealth,
> + "controller_temperature_threshold",
> jobj);
> + }
> +
> if (alarm_control & ND_SMART_SPARE_TRIP) {
> unsigned int spares;
We also seem to be missing from the listing, an
alarm_controller_temperature field to show whether or not the alarm is
enabled. Can you add that as well as part of this?
Thanks,
-Vishal
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
