On Fri, Jul 06, 2018 at 11:02:11AM -0600, Keith Busch wrote: > The informational and miscellaneous flag options are becoming more > numerous, and can be difficult to remember what can be listed. This > patch adds a 'verbose' option that increases the detail listed by > automatically enabling options and less essential information. > > The verbose option can be repeated multiple times to increase the > detail. There are currently three levels of verbose with output detail > documented in the ndctl list manpage. > > Signed-off-by: Keith Busch <[email protected]> > --- <> > @@ -112,7 +115,7 @@ static struct json_object *region_to_json(struct > ndctl_region *region, > numa = ndctl_region_get_numa_node(region); > if (numa >= 0) { > jobj = json_object_new_int(numa); > - if (jobj) > + if (jobj && flags & UTIL_JSON_VERBOSE) > json_object_object_add(jregion, "numa_node", jobj); > }
This same change needs to be repeated in the other place where we print the numa_node, in util_namespace_to_json(). The rest looks good. You can add: Reviewed-by: Ross Zwisler <[email protected]> _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
