Hi Qi,
On 07/13/2018 11:54 AM, QI Fuli wrote:
> Add a new unit test to test all options of the monitor command.
>
> Based-on-patch-by: Yasunori Goto <[email protected]>
> Acked-by: Masayoshi Mizuma <[email protected]>
> Signed-off-by: QI Fuli <[email protected]>
[...]
> +test_filter_dimmevent()
> +{
> + monitor_dimms="$(get_monitor_dimm | awk '{print $1}')"
> +
> + start_monitor "-d $monitor_dimms -D dimm-unclean-shutdown"
> + inject_smart "-U"
> + check_result "$monitor_dimms"
> + stop_monitor
> +
> + inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r
> .[]."health"."spares_threshold")
inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r "(.[]) |
.health.spares_threshold")
> + inject_value=$((inject_value - 1))
> + start_monitor "-d $monitor_dimms -D dimm-spares-remaining"
> + inject_smart "-s $inject_value"
> + check_result "$monitor_dimms"
> + stop_monitor
> +
> + inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r
> .[]."health"."temperature_threshold")
inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r "(.[]) |
.health.temperature_threshold")
The rest looks good. Please feel free to add:...
Oh, it has already added, nice :-)
> Acked-by: Masayoshi Mizuma <[email protected]>
Thanks,
Masa
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
