libnvdimm: add support for issue secure erase DSM to Intel nvdimm

Elliott, Robert (Persistent Memory) Wed, 18 Jul 2018 10:28:18 -0700


> -----Original Message-----
> From: Linux-nvdimm [mailto:[email protected]] On Behalf Of 
> Dave Jiang
> Sent: Tuesday, July 17, 2018 3:55 PM
> Subject: [PATCH v5 09/12] nfit/libnvdimm: add support for issue secure erase 
> DSM to Intel nvdimm
...
 +static int intel_dimm_security_erase(struct nvdimm_bus *nvdimm_bus,
> +             struct nvdimm *nvdimm, struct nvdimm_key_data *nkey)
...
> +     /* DIMM unlocked, invalidate all CPU caches before we read it */
> +     wbinvd_on_all_cpus();

For this function, that comment should use "erased" rather than
"unlocked".

For both this function and intel_dimm_security_unlock() in patch 04/12,
could the driver do a loop of clflushopts on one CPU via
clflush_cache_range() rather than run wbinvd on all CPUs?

---
Robert Elliott, HPE Persistent Memory




_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

RE: [PATCH v5 09/12] nfit/libnvdimm: add support for issue secure erase DSM to Intel nvdimm

Reply via email to