Hi QI, On 08/02/2018 07:42 AM, Qi, Fuli wrote: >> -----Original Message----- >> From: Masayoshi Mizuma [mailto:[email protected]] >> Sent: Thursday, August 2, 2018 3:56 AM >> To: [email protected] >> Cc: Masayoshi Mizuma <[email protected]>; Qi, Fuli/斉 福利 >> <[email protected]>; Mizuma, Masayoshi/水間 理仁 <[email protected]> >> Subject: [PATCH] ndctl, monitor: Change the fail log priority to err. >> >> From: Masayoshi Mizuma <[email protected]> >> >> fail() is called if an error happens, but the log priority is debug, so user >> may >> not notice the error. >> Let's change the priority to err. >> >> Cc: QI Fuli <[email protected]> >> Signed-off-by: Masayoshi Mizuma <[email protected]> >> --- >> ndctl/monitor.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 84d51c4..68bbf65 100644 >> --- a/ndctl/monitor.c >> +++ b/ndctl/monitor.c >> @@ -40,7 +40,7 @@ static int did_fail; >> #define fail(fmt, ...) \ >> do { \ >> did_fail = 1; \ >> - dbg(ctx, "ndctl-%s:%s:%d: " fmt, \ >> + err(ctx, "ndctl-%s:%s:%d: " fmt, \ >> VERSION, __func__, __LINE__, ##__VA_ARGS__); \ } while >> (0) >> > > Hi Masa, > > The debug messages which are from fail() include source code line numbers and > function name, > these are useful for developers not typical users. Therefore, we made it a > debug level print. > Currently the debug level cannot be outputted is a bug. > I will make a patch for adding [--verbose] option to emit debug messages and > changing the log level of some messages.
OK, make sense to me. Thanks, Masa > > Thanks, > QI > >> -- >> 2.18.0 >> >> > > _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
