Static analysis reports that we leak ndctl_cmd in the above function.
Fix by adding a proper cleanup path.
Fixes: 7271760ce96c ("libndctl, inject: inject fewer bytes per block by
default")
Signed-off-by: Vishal Verma <[email protected]>
---
ndctl/lib/inject.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/ndctl/lib/inject.c b/ndctl/lib/inject.c
index f9da02d..268c5cd 100644
--- a/ndctl/lib/inject.c
+++ b/ndctl/lib/inject.c
@@ -102,18 +102,20 @@ static int ndctl_namespace_get_clear_unit(struct
ndctl_namespace *ndns)
&ns_size);
cmd = ndctl_bus_cmd_new_ars_cap(bus, ns_offset, ns_size);
rc = ndctl_cmd_submit(cmd);
- if (rc) {
+ if (rc < 0) {
dbg(ctx, "Error submitting ars_cap: %d\n", rc);
- return rc;
+ goto out;
}
clear_unit = ndctl_cmd_ars_cap_get_clear_unit(cmd);
if (clear_unit == 0) {
dbg(ctx, "Got an invalid clear_err_unit from ars_cap\n");
- return -EINVAL;
+ rc = -EINVAL;
+ goto out;
}
-
+ rc = clear_unit;
+out:
ndctl_cmd_unref(cmd);
- return clear_unit;
+ return rc;
}
static int ndctl_namespace_inject_one_error(struct ndctl_namespace *ndns,
--
2.14.4
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
