On Fri, Aug 10, 2018 at 06:40:52PM -0600, Vishal Verma wrote: > Static analysis reports that can potentially dereference a NULL pointer > in the smart cmd error handler. This can particular instance won't ever > be hit in practice as the handler is only registered for smart commands, > and smart commands are currently only DIMM commands, and will always > have a dimm object. However for completeness, and to avoid future > errors, we should perform a NULL check in the handler anyway.
Hmm, I purposefully didn't have the NULL check because the dimm is never not set in this path. Looks like a false positive, but the NULL check is harmless. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
