On Tue, 2018-09-11 at 10:59 -0700, Dan Williams wrote: > On Tue, Sep 11, 2018 at 8:42 AM, Toshi Kani <[email protected]> wrote: > > Ext4 mount path calls ext4_iget() to obtain the journal inode. This > > inode does not support DAX, and 'ext4_da_aops' needs to be set. It > > currently works for the DAX mount case because ext4_iget() always set > > 'ext4_da_aops' to any regular files. > > > > ext4_fill_super > > ext4_load_journal > > ext4_get_journal_inode > > ext4_iget > > > > In preparation to fix ext4_iget() to set 'ext4_dax_aops' for DAX files, > > update ext4_should_use_dax() to return false for the journal inode. > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > Just a minor format recommendation: > > Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops") > Cc: <[email protected]>
Will do. > > This looks good to me. > > Reviewed-by: Dan Williams <[email protected]> Thanks! -Toshi _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
