On 09/24/2018 02:02 PM, David Howells wrote:
> Dave Jiang <[email protected]> wrote:
> 
>> +                    GLOBAL_ROOT_UID, GLOBAL_ROOT_GID, &init_cred,
> 
> Hmmm...  I wonder if current_cred() would suffice since you must be called
> from something that has the ability to load modules.  Further, I wonder if
> module loading should be wrapped in an override with init_cred in the core.
> 
>> +                    (KEY_USR_ALL & ~KEY_USR_SETATTR),
> 
> Did you really want to give the user write access, btw?

Hmmm....maybe I don't want user access at all since this is a kernel key
ring?

> 
> David
> 
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to