On Thu, Oct 4, 2018 at 9:09 PM Yasunori Goto <[email protected]> wrote: > > Hi, Vishal-san, > > > The above message was printed as an error, but it is just an > > informational message. Change it to dbg(). > > Hmmmmmmm. > > When I was a engineer for trouble-shooting of customer's Linux system, > the starting time and the ending time of any daemon was very helpful > for investigating their trouble. > > So, I think it is not only for developer, but also it is essential for > trouble-shooter for custmer support. > (It may be also same with system operator) > > > > > > Cc: QI Fuli <[email protected]> > > Cc: Dan Williams <[email protected]> > > Signed-off-by: Vishal Verma <[email protected]> > > --- > > ndctl/monitor.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ndctl/monitor.c b/ndctl/monitor.c > > index d29e378..b44f946 100644 > > --- a/ndctl/monitor.c > > +++ b/ndctl/monitor.c > > @@ -660,7 +660,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx) > > err((struct ndctl_ctx *)ctx, "daemon start failed\n"); > > goto out; > > } > > - err((struct ndctl_ctx *)ctx, "ndctl monitor daemon > > started\n"); > > + dbg((struct ndctl_ctx *)ctx, "ndctl monitor daemon > > started\n"); > > Though I agree its message is not "error" certainly, > I would like to keep it as normal status level message. >
Sounds good to me. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
