On Wed, Oct 10, 2018 at 4:36 PM Alexander Duyck <[email protected]> wrote: > > This patch set is intended to improve NVDIMM label read times by first > increasing the upper limit on the label read/write size, and then > reducing the number of reads by making use of the free label bitmap in > the index to determine what labels are actually populated and only read > those labels. In my testing on a system populated with 24 NVDIMM modules > I see the total label init time drop from about 24 seconds down to 2 to > 3 seconds. > > In the process of coding this up I came across a few minor issues that > I felt should be addressed so I have added a few patches for those fixes > along the way.
Thanks, this all looks good to me, the split looks good, and the commentary in patch6 made it easy to review. I quibble with "Remove empty if statement" because I find positive logic easier to read than negative logic, but removing more lines than it adds made me reserve that quibble for another time. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
