On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote:
> This change makes it so that we call the asynchronous probe routines on a
> CPU local to the device node. By doing this we should be able to improve
> our initialization time significantly as we can avoid having to access the
> device from a remote node which may introduce higher latency.
> 
> For example, in the case of initializing memory for NVDIMM this can have a
> significant impact as initialing 3TB on remote node can take up to 39
> seconds while initialing it on a local node only takes 23 seconds. It is
> situations like this where we will see the biggest improvement.
> 
> Signed-off-by: Alexander Duyck <alexander.h.du...@linux.intel.com>
> ---
>  drivers/base/dd.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 2fdfe45bb6ea..cf7681309ee3 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -834,7 +834,7 @@ static int __device_attach(struct device *dev, bool 
> allow_async)
>                       dev_dbg(dev, "scheduling asynchronous probe\n");
>                       get_device(dev);
>                       dev->async_probe = true;
> -                     async_schedule(__device_attach_async_helper, dev);
> +                     async_schedule_dev(__device_attach_async_helper, dev);
>               } else {
>                       pm_request_idle(dev);
>               }
> @@ -992,7 +992,7 @@ static int __driver_attach(struct device *dev, void *data)
>               if (!dev->driver) {
>                       get_device(dev);
>                       dev_set_drv_async(dev, drv);
> -                     async_schedule(__driver_attach_async_helper, dev);
> +                     async_schedule_dev(__driver_attach_async_helper, dev);
>               }
>               device_unlock(dev);
>               return 0;

Reviewed-by: Bart Van Assche <bvanass...@acm.org>

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to