On Thu, Nov 15, 2018 at 8:38 AM Leon Romanovsky <[email protected]> wrote: > > On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote: > > Em Thu, 15 Nov 2018 09:03:11 +0100 > > Geert Uytterhoeven <[email protected]> escreveu: > > > > > Hi Dan, > > > > > > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams <[email protected]> > > > wrote: > > > > Document the basic policies of the libnvdimm subsystem and provide a > > > > first example of a Subsystem Profile for others to duplicate and edit. > > > > > > > > Cc: Ross Zwisler <[email protected]> > > > > Cc: Vishal Verma <[email protected]> > > > > Cc: Dave Jiang <[email protected]> > > > > Signed-off-by: Dan Williams <[email protected]> > > > > > > Thanks for your patch! > > > > > > > --- /dev/null > > > > +++ b/Documentation/nvdimm/subsystem-profile.rst > > > > > > > +Trusted Reviewers > > > > +----------------- > > > > +Johannes Thumshirn > > > > +Toshi Kani > > > > +Jeff Moyer > > > > +Robert Elliott > > > > > > Don't you want to add email addresses? > > > Only the first one is listed in MAINTAINERS. > > > > IMO, it makes sense to have their e-mails here, in a way that it could > > easily be parsed by get_maintainers.pl. > > I personally think that list of "trusted reviewers" makes more harm than > good. It creates unneeded negative feelings to those who wanted to be in > this list, but for any reason they don't. Those reviewers will feel > "untrusted".
I'd like to +1 on this concern here. Besides leaving all the other people demotivated. A small group of trusted reviewers doesn't scale. People will get overloaded. Or you won't be able to enforce that all patches need to get Reviews. Reviews should be coming from everywhere and commiters and maintainers deciding on what to trust or re-review. Also the list is hard to maintain and keep the lists updated. > > Thanks > _______________________________________________ > Ksummit-discuss mailing list > [email protected] > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss -- Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
