On Tue, Jan 8, 2019 at 12:34 AM Johannes Thumshirn <[email protected]> wrote: > > There is no need to use Type=forking for 'ndctl monitor', Type=simple is > sufficient. > > When we use Type=forking and try to run ndctl monitor on a machine without > pmem we even get the following error in the journal: > > Jan 07 13:34:54 bragi systemd[1]: Starting Ndctl Monitor Daemon... > Jan 07 13:34:54 bragi ndctl[13776]: custom logging function 0x55ea57d60250 > registered > Jan 07 13:34:54 bragi systemd[1]: Started Ndctl Monitor Daemon. > Jan 07 13:34:54 bragi ndctl[13777]: ndctl monitor daemon started > Jan 07 13:34:54 bragi kill[13778]: kill: cannot find process "" > Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Control process > exited, code=exited status=1 > Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Unit entered failed > state. > Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Failed with result > 'exit-code'. > > This is because the daemon exits and systemd is not able to determine > $MAINPID anymore. > > Signed-off-by: Johannes Thumshirn <[email protected]>
Looks good to me. Reviewed-by: Dan Williams <[email protected]> _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
