On Fri, Jan 11, 2019 at 2:53 PM Vishal Verma <[email protected]> wrote: > > Add a new routine to ndctl_dimm_ops that allows a DSM family to provide > a translation routine that will translate the status codes of the result > of a DSM to generic errno style error codes. To use this routine > effectively, add a new wrapper around ndctl_cmd_submit (called > ndctl_cmd_submit_xlat) that submits the command, and also runs it > through the above translator dimm_op (if one is is defined). > > Cc: Dan Williams <[email protected]> > Signed-off-by: Vishal Verma <[email protected]> [..] > +NDCTL_EXPORT int ndctl_cmd_submit_xlat(struct ndctl_cmd *cmd) > +{ > + int rc; > + > + rc = ndctl_cmd_submit(cmd); > + if (rc < 0) > + return rc; > + > + /* > + * NOTE: This loses a positive rc which happens in the case of a > + * buffer underrun. If the caller cares about that (usually not very > + * useful), then the xlat function is available separately as well. > + */
Hmm, yes not very useful in general but if ndctl_cmd_xlat_firmware_status() returns 0, why not preserve the positive value if available? Just to keep the 2 interfaces more closely aligned. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
