> -----Original Message----- > From: Linux-nvdimm [mailto:[email protected]] On Behalf Of > Oliver O'Halloran > Sent: Tuesday, January 29, 2019 8:49 AM > To: [email protected] > Subject: [PATCH v4 1/5] libndctl: Use the supported_alignment attribute > > Reworded comment about why we default to 4K and 2M alignments when > the sysfs attribute is missing. ... > + /* > + * The supported_alignments attribute was added before arches other > + * than x86 had pmem support. If the kernel doesn't provide the > + * attribute then it's safe to a attribute then it's safe to assume > + * that we are on x86 which will always support 2MB and 4KB "then it's safe to a attribute" is extraneous. Also, please use MiB and KiB everywhere. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
RE: [PATCH v4 1/5] libndctl: Use the supported_alignment attribute
Elliott, Robert (Persistent Memory) Tue, 29 Jan 2019 10:17:47 -0800
- [PATCH v4 1/5] libndctl: Use the suppo... Oliver O'Halloran
- [PATCH v4 3/5] ndctl/namespace: U... Oliver O'Halloran
- [PATCH v4 5/5] ndctl: Add alignme... Oliver O'Halloran
- [PATCH v4 4/5] ndctl/namespace: V... Oliver O'Halloran
- [PATCH v4 2/5] ndctl/namespace: C... Oliver O'Halloran
- RE: [PATCH v4 1/5] libndctl: Use ... Elliott, Robert (Persistent Memory)
