commit 62bbfce3cb62 ("libndctl, intel: Add infrastructure for
firmware_status translation") has the unfortunate side effect of making
all NDCTL commands fail with -ENOMSG unless an xlat_firmware_status
function is defined for the DIMM family. This means that none of the
DIMM label manipulation commands work anymore, unless you happen to be
using an Intel DIMM.Cc: Vishal Verma <[email protected]> Fixes: 62bbfce3cb62 ("libndctl, intel: Add infrastructure for firmware_status translation") Signed-off-by: Oliver O'Halloran <[email protected]> --- ndctl/lib/libndctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c index 06f835d76117..80d107394a74 100644 --- a/ndctl/lib/libndctl.c +++ b/ndctl/lib/libndctl.c @@ -2846,6 +2846,9 @@ NDCTL_EXPORT int ndctl_cmd_submit_xlat(struct ndctl_cmd *cmd) * useful), then the xlat function is available separately as well. */ xlat_rc = ndctl_cmd_xlat_firmware_status(cmd); + if (xlat_rc == -ENOMSG) + return rc; + return (xlat_rc == 0) ? rc : xlat_rc; } -- 2.20.1 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
