commit 62bbfce3cb62 ("libndctl, intel: Add infrastructure for
firmware_status translation") has the unfortunate side effect of making
all NDCTL commands fail with -ENOMSG unless an xlat_firmware_status
function is defined for the DIMM family. A failure to translate just
means proceed with the information that we do have, not report a
command failure.
Fixes: 62bbfce3cb62 ("libndctl, intel: Add infrastructure for firmware_status
translation")
Reported-by: Oliver O'Halloran <[email protected]>
Based-on-patch-by: Dan Williams <[email protected]>
Signed-off-by: Vishal Verma <[email protected]>
---
ndctl/lib/libndctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
index 830b791..2fa8916 100644
--- a/ndctl/lib/libndctl.c
+++ b/ndctl/lib/libndctl.c
@@ -2710,7 +2710,7 @@ NDCTL_EXPORT int ndctl_cmd_xlat_firmware_status(struct
ndctl_cmd *cmd)
struct ndctl_dimm_ops *ops = dimm ? dimm->ops : NULL;
if (!dimm || !ops || !ops->xlat_firmware_status)
- return -ENOMSG;
+ return 0;
return ops->xlat_firmware_status(cmd);
}
--
2.20.1
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
