On Thu, 2019-01-24 at 16:07 -0700, Dave Jiang wrote:
> Add support for disable security to libndctl and also command line option
> of "disable-passphrase" for ndctl. This provides a way to disable security
> on the nvdimm.
>
> Signed-off-by: Dave Jiang <[email protected]>
> ---
> Documentation/ndctl/Makefile.am | 3 ++-
> Documentation/ndctl/ndctl-remove-passphrase.txt | 26 ++++++++++++++++++++++
> ndctl/builtin.h | 1 +
> ndctl/dimm.c | 23 ++++++++++++++++++++
> ndctl/lib/dimm.c | 9 ++++++++
> ndctl/lib/libndctl.sym | 1 +
> ndctl/libndctl.h | 1 +
> ndctl/ndctl.c | 1 +
> ndctl/util/keys.c | 27
> +++++++++++++++++++++++
> ndctl/util/keys.h | 6 +++++
> 10 files changed, 97 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ndctl/ndctl-remove-passphrase.txt
[..]
> diff --git a/ndctl/ndctl.c b/ndctl/ndctl.c
> index 5cb5fa4f..9f4ab234 100644
> --- a/ndctl/ndctl.c
> +++ b/ndctl/ndctl.c
> @@ -90,6 +90,7 @@ static struct cmd_struct commands[] = {
> { "start-scrub", { cmd_start_scrub } },
> { "setup-passphrase", { cmd_passphrase_setup } },
> { "update-passphrase", { cmd_passphrase_update } },
> + { "remove-passphrase", { cmd_passphrase_remove } },
Same comment as patch 2 about s/passphrase_remove/remove_passphrase/
here. I think the remaining new commands in this series do this
correctly, i.e. *-verb-object for command names and function names.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
