Static analysis reports that we potentially leak 'fname' in the above function. Fix by freeing it as well as 'blob' in the exit path.
Signed-off-by: Vishal Verma <[email protected]> --- ndctl/load-keys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ndctl/load-keys.c b/ndctl/load-keys.c index 184fa2d..95c4d4d 100644 --- a/ndctl/load-keys.c +++ b/ndctl/load-keys.c @@ -86,7 +86,7 @@ static int load_dimm_keys(struct loadkeys *lk_ctx) { int rc; struct dirent *dent; - char *fname, *id, *blob; + char *fname = NULL, *id, *blob = NULL; char desc[ND_KEY_DESC_SIZE]; int size, count = 0; key_serial_t key; @@ -142,6 +142,8 @@ static int load_dimm_keys(struct loadkeys *lk_ctx) printf("%d nvdimm keys loaded\n", count); + free(fname); + free(blob); return 0; } -- 2.20.1 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
