> -----Original Message----- > From: Dexuan Cui <[email protected]> > Sent: Saturday, February 16, 2019 4:26 PM > To: Qi, Fuli <[email protected]>; Dave Jiang <[email protected]>; > Vishal Verma <[email protected]>; Dan Williams > <[email protected]>; > [email protected] > Cc: Michael Kelley <[email protected]> > Subject: RE: [ndctl PATCH] ndctl, monitor: support NVDIMM_FAMILY_HYPERV > > > From: [email protected] <[email protected]> > > Sent: Friday, February 15, 2019 1:26 AM > > > ... > > > --- a/ndctl/monitor.c > > > +++ b/ndctl/monitor.c > > > @@ -265,31 +265,50 @@ static bool filter_region(struct ndctl_region > > *region, > > > return true; > > > } > > > > > > -static void filter_dimm(struct ndctl_dimm *dimm, struct > > > util_filter_ctx *fctx) > > > +static bool ndctl_dimm_test_and_enable_notification(struct > > > +ndctl_dimm > > *dimm) > > > { > > > - struct monitor_dimm *mdimm; > > > - struct monitor_filter_arg *mfa = fctx->monitor; > > > const char *name = ndctl_dimm_get_devname(dimm); > > > > > > + /* > > > + * Hyper-V Virtual NVDIMM doesn't use ND_CMD_SMART to get the > > > health > > > + * info. Instead, it uses ND_CMD_CALL, so the checking here can't > > > + * apply, and it doesn't support threshold alarms. > > > + */ > > > + if (ndctl_dimm_get_cmd_family(dimm) == NVDIMM_FAMILY_HYPERV) > > > + return true; > > > > Hi, > > > > I think it would be better to add a checking monitor.event_flags step here. > > Users should be notified if they setup monitoring smart threshold > > events on NVDIMM_FAMILY_HYPERV. > > > > QI > > Hi Qi, > Unluckily NVDIMM_FAMILY_HYPERV doesn't support monitoring smart threshold > events. Please see the _DSM Interface for Hyper-V Virtual NVDIMM at > https://uefi.org/RFIC_LIST (Virtual NVDIMM 0x1901). > > So there is no ops->new_smart_threshold defined for NVDIMM_FAMILY_HYPERV. > > The patch only skips the checks for NVDIMM_FAMILY_HYPERV, and the behavior for > the others remains the same. > > Thanks, > -- Dexuan
Hi Dexuan, I am sorry I didn't explain it clearly enough. I want to say that users may not know that NVDIMM_FAMILY_HYPERV doesn't support monitoring smart threshold events. If users setup monitoring smart threshold events on NVDIMM_FAMILY_HYPERV by mistake, it would be more friendly to send them a notification. Thanks, Qi _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
