On Sat, Feb 23, 2019 at 5:29 PM Vishal Verma <[email protected]> wrote: > > On Fri, 2019-02-22 at 16:24 -0800, Dan Williams wrote: > > Looks ok, but I think the changelog could be more accurate. > > > > On Fri, Feb 22, 2019 at 3:59 PM Vishal Verma <[email protected]> > > wrote: > > > Add a 'modalias' attribute to devices under the DAX bus so that userspace > > > is able to dynamically load modules as needed. > > > > The modalias is already published in the uevent which is how udev > > identifies the module. This patch would allow "modalias to module > > lookups" *outside* of the typical uevent used for dynamically loading > > modules. > > > > Care to fix up the changelog with that detail and why userspace needs > > to do these lookups in addition to the typical uevent lookups? > > > > Yes, thanks for the feedback, I think this reads better: > > 8<---- > > From 1e399f52f21c22e4c4bd5d48b26f539e12342beb Mon Sep 17 00:00:00 2001 > From: Vishal Verma <[email protected]> > Date: Fri, 22 Feb 2019 16:58:54 -0700 > Subject: [PATCH v2] dax: add a 'modalias' attribute to DAX 'bus' devices > > Add a 'modalias' attribute to devices under the DAX bus so that userspace > is able to dynamically load modules as needed. > > Normally, udev can get the modalias from 'uevent', and that is correctly > set up by the DAX bus. However other tooling such as 'libndctl' for > interacting with drivers/nvdimm/, and 'libdaxctl' for drivers/dax/ can > also use the modalias to dynamically load modules via libkmod lookups. > > The 'nd' bus set up by the libnvdimm subsystem exports a modalias > attribute. Imitate this to export the same for the 'dax' bus. > > Cc: Dan Williams <[email protected]> > Cc: Dave Hansen <[email protected]> > Signed-off-by: Vishal Verma <[email protected]>
Looks good, Reviewed-by: Dan Williams <[email protected]> _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
