On Wed, 2019-02-27 at 21:06 +0000, Dexuan Cui wrote:
> > From: Verma, Vishal L <[email protected]>
> > Sent: Wednesday, February 27, 2019 10:13 AM
> > ...
> > > I suppose the new line should not be added, and the line
> > > if (ent_e_flag(log_new.old_map)) {
> > > should be changed to
> > > if (ent_e_flag(log_new.old_map) && !
> > ent_z_flag(log_new.old_map)) {
> > > ?
> > >
> > Ah yes good catch, I broke my own rule, in that freelist[i].block should
> > not have flag bits since it is used as is. The freelist has a separate
> > has_err field to allow for error clearing, and we should be setting
> > that.
> >
> > Does the following incremental patch fix it? Let me know and I can send
> > a new version including it.
>
> Yes, the patch works for me. Thank you!
>
> But, should we really set the has_err field? Here the enry has both
> the zere/error flags set. As I understand, this is not an error, because
> the UEFI spec says "... both Error and Zero are set to indicate a map entry
> in its normal, non-error state".
>
Ah yes I see what you mean - we'd be pointlessly trying to clear those
blocks. I'll fix this in v5.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
