On Fri, Mar 01, 2019 at 02:49:54PM +0100, Jan Kara wrote:
> >     pfn = dax_to_pfn(entry);
> > -   size = PAGE_SIZE << dax_entry_order(entry);
> > +   count = 1UL << dax_entry_order(entry);
> > +   index = xas->xa_index &~ (count - 1);
> 
> Hum, why do you compute 'index' here when you actually never use it? The
> whole patch looks fishy since it is effectively a noop AFAICT...

*facepalm*.  I lost the change to the next line while I was backing out
some extraneous changes.

> >     dax_entry_mkclean(mapping, xas->xa_index, pfn);

Replacement patch sent.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to