On Tue, 2019-02-12 at 13:28 -0800, Dan Williams wrote: > Allow for easier comparisons between 'read-labels' output and list. > > Signed-off-by: Dan Williams <[email protected]> > --- > ndctl/dimm.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/ndctl/dimm.c b/ndctl/dimm.c > index 292beebf9734..5ff730f42a45 100644 > --- a/ndctl/dimm.c > +++ b/ndctl/dimm.c > @@ -50,6 +50,7 @@ static struct parameters { > bool crypto_erase; > bool overwrite; > bool master_pass; > + bool human;
Should --human also imply --json? It doesn't make sense to have human for binary data, so it might be surprising if --human doesn't output json. Also I think this is missing the man page update to add --human (and that would be a good place to clarify the human/json behavior). Looks good otherwise. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
