> From: Verma, Vishal L <[email protected]> > Sent: Wednesday, March 27, 2019 9:17 AM > To: Williams, Dan J <[email protected]>; Dexuan Cui > <[email protected]>; Jiang, Dave <[email protected]>; > [email protected]; [email protected]; Michael Kelley > <[email protected]> > Cc: [email protected]; [email protected] > Subject: Re: [ndctl PATCH v3 4/5] libndctl: Add a new dimm-op > cmd_is_supported() > > > On Tue, 2019-03-26 at 23:29 +0000, Dexuan Cui wrote: > > > Here ndctl is checking if ND_CMD_SMART is supported in > > dimm->cmd_mask. For all the non-NVDIMM_FAMILY_INTEL families, > > the check is false, including the HPE1 and MSFT families. > > > > So IMO we need this new dimm-ops to make "ndctl monitor" work > > for Hyper-V. I think the other non-INTEL families can't work with > > "ndctl monitor" either, but I don't have a hardward to test. > > > Ah ok makes sense - I think with that I don't have any other comments - > I'll queue the patches for the pending branch. > > Thanks, > -Vishal
Great! Thanks you! -- Dexuan _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
