On Thu, Jun 6, 2019 at 10:26 PM Santosh Sivaraj <[email protected]> wrote: > > For QEMU emulated devices, nfit drivers need not be loaded, also the > nfit_test, libnvdimm_test modules are not required. This patch adds a > configure option to enable testing on qemu without nfit dependencies.
This looks useful, I only quibble with it being a compile time option. I'd prefer an environment variable to allow this to be overridden at test run time, perhaps "WITH_NFIT". You can have a compile time option to set the WITH_NFIT default, but otherwise it would be useful to be able to disable NFIT requiring tests even on x86. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
